Rework orphan block validation (validate_pow_only) #3172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call
validate_pow_only()
early in the block processing pipeline to prevent invalid blocks being added to the orphan block pool but we can do this earlier and in a cleaner way.We need less conditional logic around these validation steps.
This PR updates the initial validation steps in
process_block
so we callvalidate_pow_only()
before hitting the db for chain head and previous header.Also took the opportunity to clean
validate_pow_only()
up a little to read better.Note: We are in the unfortunate position of having tests dependent on headers with invalid pow. We need to return early in
validate_pow_only()
if the ctx includesSKIP_POW
. This is only used in tests.We should make a note to follow up with some effort to get rid of
SKIP_POW
entirely.