Allow rest api to shutdown #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good. Do you know why we can reenable this now? |
|
As far as I got after conversation with @hashmap there was a temporary bug in hyper version, which is now fixed. I've tested it as a part of Ironbelly and it shutdowns the API properly. |
quentinlesceller
approved these changes
Mar 25, 2021
quentinlesceller
added a commit
that referenced
this pull request
Mar 28, 2021
This reverts commit 4a09fed.
quentinlesceller
added a commit
that referenced
this pull request
Mar 29, 2021
|
@i1skn seems like the API does not start with this change. |
|
@quentinlesceller Hi, is there any specific reason or case when it does not start? |
|
Basically any call on the API will just fail. The server is not listening. |
sheldonth
added a commit
to sheldonth/grin
that referenced
this pull request
Nov 21, 2021
…lewimble#3625)" This reverts commit 25d93c8.
sheldonth
added a commit
to sheldonth/grin
that referenced
this pull request
Nov 21, 2021
…down Revert "Revert "Allow rest api to shutdown (mimblewimble#3614)" (mimblewimble#3625)"
sheldonth
added a commit
to sheldonth/grin
that referenced
this pull request
Nov 23, 2021
sheldonth
added a commit
to sheldonth/grin
that referenced
this pull request
Nov 23, 2021
…-api-shutdown Revert "Revert "Revert "Allow rest api to shutdown (mimblewimble#3614)" (mimblewimble#3625)""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can re-enable this functionality,
grin-walletalso uses this crate and it's good to have an ability to shutdown the api without killing the process.