Updated contributing.md links. #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed grin support link to keybase grincoin#support channel - Changed Grin lobby link to keybase grincoin#general channel - Changed developer channel to keybase grincoin#dev - Changed @grincoincil twitter account to reddit/grincoin channel for news and developments. - Added doc.grin.mw link for general grin information.
phyro
reviewed
Jul 2, 2022
CONTRIBUTING.md
Outdated
| * Further information and discussions are in the [Forum](https://forum.grin.mw), the [website](https://grin.mw), the [mailing list](https://lists.launchpad.net/mimblewimble/) and news channels like the [@grincouncil](https://twitter.com/grincouncil) and a (mostly unfiltered!) Twitter bot that collects headlines, mailing list posts, and reddit posts related to Mimblewimble/Grin: [@grinmw](https://twitter.com/grinmw) | ||
| * See `docs/*.md` and the folder structure explanations, and [the wiki](https://github.com/mimblewimble/docs/wiki). | ||
|
|
||
| * Also visit [Grin Docs and Resources]( https://docs.grin.mw/ ) for understanding and getting started Grin. |
There was a problem hiding this comment.
This sentence would be best if coupled with the one above which is also about documentation e.g.
Also see
docs/*.mdand the folder structure explanations, the wiki, and the official Grin documentation.
P.S. there are some spaces in the links which can be removed
There was a problem hiding this comment.
Edited as you proposed, and removed space in the link.
phyro
approved these changes
Jul 2, 2022
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: contributing.md update
about: updated gitter.im/grin_community channel links to keybase
If your PR is a work in progress, please feel free to create it and include a [WIP] tag in the PR name. We encourage everyone to PR early and often so that other developers know what you're working on.
Before submitting your PR for final review, please ensure that it: