Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add React leaderboard/Hall of Fame #106

Merged
merged 3 commits into from
Mar 10, 2019

Conversation

nijynot
Copy link
Member

@nijynot nijynot commented Mar 7, 2019

Fixes mimblewimble/grin-pm#52.

  • To add a new donation to the leaderboard/Hall of Fame, insert a row to income_log.csv. Total, last donation, number of donations, and the "dropdown history" will be automatically updated from that.
  • If a new company/individual is being added to the leaderboard, don't forget to add them to the entities.csv (currently in assets/csv/entities.csv) file too. Editing the description, name, profile image or link of a company/individual is done in entities.csv.

One caveat is that the "name" (source in income_log.csv and name in entities.csv) must be the same when referenced. It's case insensitive, but does not trim whitespace.

Threshold for showing up on leaderboard is $25,000, so it'll be empty as of now.

@nijynot nijynot changed the title Leaderboard5 add React leaderboard/Hall of Fame Mar 7, 2019
Copy link
Contributor

@lehnberg lehnberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @nijynot thanks a lot for this! I've not tested it in action but took a look at the HTML and CSV structure of entities.csv, great job. Once merged I can add more info about the leaderboard and how it works on the page itself. 👍

@garyyu
Copy link
Contributor

garyyu commented Mar 11, 2019

Thanks @nijynot, this implementation is awesome 👍 😃
Let's start using this nice Hall of Fame feature :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants