Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete old layer code #42

Merged
merged 6 commits into from
Mar 13, 2024
Merged

delete old layer code #42

merged 6 commits into from
Mar 13, 2024

Conversation

rompetroll
Copy link
Contributor

@rompetroll rompetroll commented Mar 5, 2024 •
edited
Loading

also migrate tests to built-in

remaining:

  • proofread readme
  • add license headers
  • replace jsons library
  • test all functions
  • read implicit
  • read configured dataset with mapping
  • incr implicit
  • incr configured dataset with mapping
  • fullsync implicit
  • fullsync configured dataset with mappings

@rompetroll rompetroll marked this pull request as ready for review March 12, 2024 15:53
gra-moore
gra-moore requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@gra-moore gra-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/snowflake-datalayer/main.go Show resolved Hide resolved
@rompetroll rompetroll merged commit fc80776 into master Mar 13, 2024
4 checks passed
@rompetroll rompetroll deleted the chore/os branch March 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gra-moore gra-moore gra-moore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rompetroll @gra-moore