Use set -e to fail fast
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
Seems this should be in the bash template: https://github.com/nadarei/mina/blob/master/data/deploy.sh.erb Rather than inserted in the ssh helper. |
|
Hell, I haven't been doing programming things for a long time and I'm recovering from it. Since the previous patch is long outdated I just did a new commit and did a forced update to my branch w/ the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just got started to use mina today. And I noticed that even if some command when deploying exits with a non-zero status, the following commands would still execute. I really don't want that to happen since I simply don't want to know what would happen in that situation.
This patch makes use of bash's
-eoption and bail out asap if any command goes bad. Jenkins CI uses this. And I think deploying scripts are even more critical than CI scripts.Hope it gets merged :)