Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binstubs options from defaults #219

Merged
merged 1 commit into from
Aug 28, 2014
Merged

Remove binstubs options from defaults #219

merged 1 commit into from
Aug 28, 2014

Conversation

lucapette
Copy link
Contributor

See #162

gabskoro added a commit that referenced this pull request Aug 28, 2014
Remove binstubs options from defaults
@gabskoro gabskoro merged commit 76b5343 into mina-deploy:master Aug 28, 2014
@lucapette
Copy link
Contributor Author

oh that was fast! Thank you for merging it!

@vaz
Copy link

vaz commented Jan 21, 2015

This is fine and all, I understand the rationale re: Rails 4, but this should not have been published in a patch-level update (0.3.1).

My god scripts have been calling the release's bin/unicorn and I just had a site die on me during a deployment because of that. mina/god/unicorn is my zero-downtime solution, it sucks to have a tool surprise me and cause a failure like that. If it was even a minor version update then it would have been my own fault for not checking the changelog, but of course I have mina locked to "~> 0.3.0".

Anyway just giving you a heads-up. It's easy to forget that "public API" includes more than just Ruby methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants