Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependency #6

Closed
wants to merge 1 commit into from
Closed

update dependency #6

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2021

That could help fedora update a few package

@mina86
Copy link
Owner

mina86 commented Jun 19, 2021

Unfortunately it’s not as simple. delta_e uses lab 0.7 in its dependency. This doesn’t matter when using DE200::from_rgb method (which is what the main code is using) but it does matter when using DE2000::new which is what code in tools directory uses. delta_e hasn’t been updated in two years and PRs just stagnate there. I’m honestly tempted to just fork it.

@ghost
Copy link
Author

ghost commented Jun 19, 2021

Ok. So i remove the update for lab in tools cargo.toml

@mina86 mina86 closed this in 4e9ad21 Jun 20, 2021
mina86 added a commit that referenced this pull request Jul 1, 2021
@mina86
Replace delta_e depedency with empfindung
eef25ed 
This removes dependency on ancient lab versions which we were forced to
use due to delta_e lack of maintenance.

Issue: #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mina86