Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ApplyWithForce test in pre-release #131

Merged
merged 1 commit into from
May 22, 2023

Conversation

minamijoyo
Copy link
Owner

A pre-release can only be compared between pre-releases due to the limitations of the hashicorp/go-version libraries and will not behave as expected.
hashicorp/go-version#35

On the other hand, the ApplyWithForce test is a legacy one that can only be tested before 1.1 and does not need to be tested on pre-releases 1.1+. So we can skip it if pre-release.

A pre-release can only be compared between pre-releases due to the
limitations of the hashicorp/go-version libraries and will not behave as
expected.
hashicorp/go-version#35

On the other hand, the ApplyWithForce test is a legacy one that can only
be tested before 1.1 and does not need to be tested on pre-releases
1.1+. So we can skip it if pre-release.
@minamijoyo minamijoyo merged commit eb1dd4c into master May 22, 2023
@minamijoyo minamijoyo deleted the skip-apply-with-force-test-in-prerelease branch May 22, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant