Add proxy settings #1202
Merged
Add proxy settings #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalmerAL
reviewed
Aug 17, 2020
There was a problem hiding this comment.
I think this looks fine in general, although I think the UI could probably be simplified (as I mentioned in my review comment).
Have you been able to test all these options and confirm that they work? I don't have a proxy to use, and I'm not aware of any way I can get one for free, so I don't have any way to test this.
I've been testing these on Linux Mint 20 and Windows 7, and they work for me. |
|
Everything looks good to me; thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82