Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method == true in base.py #130

Merged

Conversation

Lenoush
Copy link
Contributor

@Lenoush Lenoush commented Jun 12, 2024

add

if not method:
self.density = None
return None
if method is True and hasattr(self, "pipe"):
method = "pipe"

@Lenoush Lenoush requested a review from paquiteau June 12, 2024 14:19
@Lenoush Lenoush linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues

src/mrinufft/operators/base.py Outdated Show resolved Hide resolved
@chaithyagr chaithyagr merged commit 96ad286 into master Jun 26, 2024
8 checks passed
@chaithyagr chaithyagr deleted the 125-add-case-method-==-true-in-compute_density-in-basepy branch June 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add case method == True in compute_density() in base.py
3 participants