-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twixtools and orientation matrix extraction #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! I have made a suggestion for more pythonic code. Also you need to run black/ ruff on your code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think Only Pierre's comments makes sense and some code linting. Ideally we need a test, but thats hard as we need to create dummy data. Lets skip testing this module but maybe @mbertrait can you open an issue if its not already present to track the need for a test?
A minor comment, if you can it could help to just tell here is twixtools is faster or pymapvbvd. It doesnt have to be an extensive test. Careful though, we dont want bad numbers just because data was in cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change pymapvbvd
to twixtools
with the right github link in pyproject.toml
@paquiteau to comment how to specify gitghub link, as twixtools is not released by authors.
I thought about tests but then as you mentioned we need dummy data so I set them aside for the moment. |
Co-authored-by: Pierre-Antoine Comby <pierre-antoine.comby@ens-paris-saclay.fr>
@paquiteau I found a syntax you can find in 612cfd9. Need your expertise on this |
This PR solves #153 by moving from mapVBVD to twixtools to read Siemens Twix scan files and storing the orientation matrix in the
hdr
dict.