Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add unix time stand for unicity. #171

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: add unix time stand for unicity. #171

merged 2 commits into from
Jul 30, 2024

Conversation

paquiteau
Copy link
Member

@paquiteau paquiteau commented Jul 29, 2024 •
edited
Loading

Solves #170 ✔️

@paquiteau paquiteau requested a review from chaithyagr July 29, 2024 18:59
@paquiteau paquiteau linked an issue Jul 29, 2024 that may be closed by this pull request
Prevent saving temporary images on /tmp in examples #170
Closed
chaithyagr
chaithyagr requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should in any case just create the images within the same folder? I'm worried if the time stamp is not enough for unicity, as all could have same time when we run with parallel

@paquiteau
Copy link
Member Author

honestly, having the same timestamp, down to the tenth of microsecond (time.time() is a float !) should be rare enough not to happen. It is a risk I am willing to take :D otherwise, we could a swell add os pid in the hash but that may be just overkill

chaithyagr
chaithyagr approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. For now this is not done in the learning example, but I think thats okay for now.

@paquiteau paquiteau merged commit e7d7661 into master Jul 30, 2024
11 checks passed
@paquiteau paquiteau deleted the fix-example-hash branch July 30, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaithyagr chaithyagr chaithyagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent saving temporary images on /tmp in examples
2 participants
@paquiteau @chaithyagr