Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks for stacked nufft #173

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Some tweaks for stacked nufft #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2cbb90
fix(test): make stacked-gpu tests run.
paquiteau Aug 1, 2024
83cdca0
feat: make z_index default to "auto"
paquiteau Aug 1, 2024
28ae352
docs: z-index computation.
paquiteau Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/mrinufft/operators/stacked.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ class MRIStackedNUFFT(FourierOperatorBase):
shape: tuple
Shape of the image.
z_index: array-like
Cartesian z index of masked plan.
Cartesian z index of masked plan. if "auto" the z_index is computed from the
samples, if they are 3D, using the last coordinate.
backend: str or FourierOperatorBase
Backend to use.
If str, a NUFFT operator is initialized with str being a registered backend.
Expand Down Expand Up @@ -74,9 +75,9 @@ def __init__(
self,
samples,
shape,
z_index,
backend,
smaps,
z_index="auto",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps update the docs also for it?

n_coils=1,
n_batchs=1,
squeeze_dims=False,
Expand Down Expand Up @@ -353,7 +354,8 @@ class MRIStackedNUFFTGPU(MRIStackedNUFFT):
shape: tuple
Shape of the image.
z_index: array-like
Cartesian z index of masked plan.
Cartesian z index of masked plan. if "auto" the z_index is computed from the
samples, if they are 3D, using the last coordinate.
smaps: array-like
Sensitivity maps.
n_coils: int
Expand All @@ -371,11 +373,11 @@ def __init__(
self,
samples,
shape,
z_index,
smaps,
n_coils=1,
n_batchs=1,
n_trans=1,
z_index="auto",
squeeze_dims=False,
smaps_cached=False,
density=False,
Expand Down
1 change: 1 addition & 0 deletions tests/helpers/factories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def wrapper(operator, array_interface, *args, **kwargs):
"gpunufft",
"torchkbnufft-gpu",
"tensorflow",
"stacked-cufinufft",
]:
pytest.skip("Uncompatible backend and array")
if array_interface in ["torch-cpu", "numpy"]:
Expand Down
Loading