-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MaxRecursionDepth error, Memory leaks and move to CUDA12 #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work ! moving to cuda12 is really nice. We should probably make a release after this.
I have some minor comments/suggestions to address before that though ;)
.github/workflows/test-ci.yml
Outdated
@@ -282,7 +280,7 @@ jobs: | |||
BuildDocs: | |||
name: Build API Documentation | |||
runs-on: gpu | |||
if: ${{ (contains(github.event.head_commit.message, 'docs_build')) || (github.ref == 'refs/heads/master')}} | |||
if: ${{ !(contains(github.event.head_commit.message, 'docs_build')) || (github.ref == 'refs/heads/master') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so whats the expected behavior ? one needs to put docs_build
to skip the building of the documentation ? seems weird to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its weird, when I added this, it is building .. I am lost but it works :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clear this then, We should build the doc:
- In PR to master, when the
docs_build
keyword is present. - On every commit to master (aka after merge)
I think we should use github.head_ref
(and the contains)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ref aspect is fine. The containts part doesnt work. I am trying to understand whats broken. For some reason it does not trigger even when I use docs_build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay this is broken. For now, we dont check docs_build
and also style
. (Cause github.event.head_commit
is empty if the event is triggered with pull_request
I will open an issue (#176) to fix this, but its not easy :P
We can proceed with current PR for now
Co-authored-by: Pierre-Antoine Comby <pierre-antoine.comby@crans.org>
We had some issues of MaxRecurssionDepth, which was fixed and on extensively testing, I saw a memory leak in gpuNUFFT (fixed in chaithyagr/gpuNUFFT#23). Some more memory leaks from cuFFT comes from from CUDA11.8: https://forums.developer.nvidia.com/t/nvc-cufft-memory-leak/279476/3
To fix this, we moved to using CUDA12.1, which is default version which comes with
torch
.Also have a bunch of other miscellaneous tasks:
int
values forblurr_factor
.