Fix violation check rule

[chaithyagr]

No description provided.

[paquiteau]

Why don't you just negate the array in your code ? :D

[chaithyagr]

Ahhh you want to have bugs to fix bugs, nice xD
Shall i change this line

mri-nufft/src/mrinufft/io/nsp.py

Lines 237 to 242 in 57765d5

	if violation:
	warnings.warn(
	"Hard constraints violated! "
	f"Maximum gradient amplitude: {maxG:.3f} > {gmax:.3f}"
	f"Maximum slew rate: {maxS:.3f} > {smax:.3f}"
	)

to if not violation:, then warn? :P

[paquiteau]

or s/violation/valid/ and then if not all(valid): ?

[chaithyagr]

Just approve and merge bro xD

[chaithyagr]

Lol I didn't think this PR will have su much discussion xD I thought it would be, oops missed that

[Daval-G]

I tend to agree with @paquiteau, why change this function when it is just misused ? We can surely discuss whether those functions should check validity or violation, but for now the only bug is in mri-nufft/src/mrinufft/io/nsp.py

[chaithyagr]

I give up xD