-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Conjugate Gradient with Momentum #185
Conversation
I think this would be more suited in |
@Lenoush I think I agree with @paquiteau, can we move this to extras module. Also it would help to have test and an example? |
… into add-cg-method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good !
The example deserves more explanation (add a ref to the CG algorithm, Wikipedia is okay)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In base.py , add a first draft of cg function with
cg(self, kspace_data, x_init=None, num_iterations=10, tol=1e-4)
where x_init = initial image , tol = tolerance
Classique example of gradient descent :
Help of :