-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean CPU examples #196
Clean CPU examples #196
Conversation
By the way, how can we change the examples order in the gallery ? It doesn't make sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvements, thanks!
If you wish, you can also tackle #182 in this as well.
RTFM 🙃 https://sphinx-gallery.github.io/stable/configuration.html#within-gallery-order there are multiple possibilities; I guess |
Done |
For now let's sort by example name rather than filename, until we decide of a specific order |
@paquiteau I cleaned the new CG example who seem to be problematic even on the main branch, but even after fixing it doesn't work as intended on my side (image not showing because the algorithm doesn't converge). I moved it to GPU examples because it uses gpuNUFFT even though I doubt it is a requirement, but since it didn't work on my side I didn't want to change too many things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks again :)
Don't worry for the CG example, we will take care of it later (@Lenoush ?)
This PR cleans the CPU examples in several ways:
I will try to do the same for GPU examples later. Note that trajectory examples are barely touched, not because they are perfect but the opposite as I plan to break them into smaller examples as discussed in #118.