Random sampling #220
Merged
Random sampling #220
+398
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Daval-G What do you think of this updated version ? also do not hesitate to check the example as well |
paquiteau
force-pushed
the
stack-random
branch
from
2ece4be to
c4dc349
Compare
paquiteau
force-pushed
the
stack-random
branch
from
c4dc349 to
630486c
Compare
|
@paquiteau I am starting again to look at this request, but I won't finish tonight. I see that a bunch of my old comments are un-answered, could you have a look ? Thx |
|
I think now I have address everything you asked for :) |
Daval-G
requested changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds random sampling extension for trajectories.
In particular, it adds a trajectory expansion function (
stack_random) to stack 2D trajectory following a certain distribution.([ ] Add ND sampling (e.g poisson disc))An example of stack of spiral with uniform sampling (but fully sampled in the center of k-space)
