-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trajectory display overhaul #37
Trajectory display overhaul #37
Conversation
We should probably set up a discussion in the coming weeks to see notably how to interface your nice contributions to mri-nufft with the brand new fMRI simulator developed by @paquiteau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very promising, the gradient plot are exactly what I had in mind. There is surely some docs effort to make but this is really good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It keeps getting better !
The displayConfig can be simplified though, see my suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
This PR consists of the following features:
Currently, the documentation still needs to be written and examples updated as they are the first ones impacted by the display changes. Here is a simple rendering: