Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the display config #54

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Improve the display config #54

merged 8 commits into from
Nov 22, 2023

Conversation

paquiteau
Copy link
Member

This PR does two things:

  1. It adds convenient api to update the displayConfig temporarily with a context manager
  2. Add support for custom color cycling by sampling existing matplotlib colormap.

@paquiteau paquiteau requested a review from Daval-G November 20, 2023 13:53
@paquiteau
Copy link
Member Author

Here is a preview of the example file

image

Daval-G
Daval-G approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@Daval-G Daval-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.
Great improvement !

src/mrinufft/trajectories/display.py Show resolved Hide resolved
src/mrinufft/trajectories/display.py Show resolved Hide resolved
@paquiteau paquiteau merged commit 0f84e19 into master Nov 22, 2023
4 checks passed
@paquiteau paquiteau deleted the display-conf branch November 22, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daval-G Daval-G Daval-G approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paquiteau @Daval-G