Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propeller #56

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Propeller #56

merged 5 commits into from
Nov 22, 2023

Conversation

Daval-G
Copy link
Collaborator

@Daval-G Daval-G commented Nov 21, 2023

This PR adds the Propeller/Blade trajectory (without the associated reconstruction method) as requested in #48. The original name from the authors is kept, but common aliases will be referred to in the documentation & examples coming later.

Here is an example with 6 strips of 21 shots:

image

@Daval-G Daval-G requested a review from paquiteau November 21, 2023 23:17
@Daval-G Daval-G added the trajectories Issues concerning Non cartesian trajectories label Nov 21, 2023
paquiteau
paquiteau approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, letme know if you want to add anything more

@Daval-G Daval-G merged commit e90454e into mind-inria:master Nov 22, 2023
4 checks passed
@Daval-G Daval-G mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paquiteau paquiteau paquiteau approved these changes

Assignees
No one assigned
Labels
trajectories Issues concerning Non cartesian trajectories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daval-G @paquiteau