feat: add benchmarking code #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My personal opinion is to have this in a different repository with links in the main one. This helps decouple the main library with perf stuff making the codes more easier to maintain. Any changes in inner modules and APIs (I really hope we dont change them) will end up affecting these codes. WDYT? Do you want to maintain them to repeat perf benchmark again to better understand how good each method is with improvements (like how we want to do that now with gpuNUFFT 2.0 vs cuFINUFFT 2.2? |
paquiteau
force-pushed
the
master
branch
5 times, most recently
from
15ffa85 to
0d40152
Compare
|
What is the plan for this PR? |
|
The development of benchmark will happen in https://github.com/mind-inria/mri-nufft-benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the code for the benchmark running script.
This has still some work to do to ensure a fully reproducible pipeline (e.g. add scripts to generate the same trajectories as in ismrm, ensure the figures are the same, etc ...)