Density compensation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paquiteau
force-pushed
the
density-comp
branch
from
3ef4fd3 to
0eb2293
Compare
|
Good job @paquiteau |
chaithyagr
requested changes
Dec 15, 2023
| @@ -139,7 +139,7 @@ jobs: | |||
| run: | | |||
| cd $RUNNER_WORKSPACE | |||
| rm -rf finufft | |||
| git clone https://github.com/chaithyagr/finufft --branch chaithyagr/issue306 | |||
| git clone https://github.com/flatironinstitute/finufft | |||
There was a problem hiding this comment.
As the development of cufinufft is very active, I prefer to track directly the repo.
There was a problem hiding this comment.
We might also need to test against the latest release version as that's what users use.
By registering, I meant to have something to collect all density compensation methods and then do a get_density("cell_count")(traj, ...) |
paquiteau
force-pushed
the
density-comp
branch
4 times, most recently
from
365c4ab to
95fc0ef
Compare
paquiteau
force-pushed
the
density-comp
branch
from
95fc0ef to
784a45c
Compare
paquiteau
force-pushed
the
density-comp
branch
from
48e5b2d to
50848d8
Compare
chaithyagr
pushed a commit
to chaithyagr/mri-nufft
that referenced
this pull request
Apr 11, 2024
* feat: refactor density compensation to a module. * feat: add decorator to flatten trajectories. * feat: add ultra fast cell counting method. * refactor: use the flat_traj decorator. * refactor: make pipe a classmethod. * fix: special case for 2d trajectories. * feat: enforce common api for density compensation functions. * feat: move density module up. * feat(density): add test. * feat(cufinufft)!: drop pipe implementation and follow upstream. * fix: update module level for density. * fix: cleanup * feat(ci): Install most recent cufinufft * fix(ci): copy libcufinufft.so at the right place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors and augments the density compensation routines.
density_method(traj, shape, **kwargs).Not considered in this PR:
Footnotes
https://casadocs.readthedocs.io/en/stable/notebooks/synthesis_imaging.html#Data-Weighting ↩
https://wsclean.readthedocs.io/en/latest/weighting.html ↩