Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test refactor #83

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Test refactor #83

merged 8 commits into from
Feb 28, 2024

Conversation

paquiteau
Copy link
Member

This PR move all tests related to NUFFT operators inside tests/operators folder.

Now it is possible to select or not this test easily with

# To select
pytest -k="operators" ... 
# To unselect 
pytest -k="not operators' ... 

@paquiteau paquiteau requested a review from chaithyagr February 22, 2024 10:19
@chaithyagr
Copy link
Member

Still pynfft is very slow? Maybe we fix that?

Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paquiteau paquiteau merged commit 6f86fbb into master Feb 28, 2024
8 checks passed
chaithyagr pushed a commit to chaithyagr/mri-nufft that referenced this pull request Apr 11, 2024
* move tests on operators in folder.

* ci: split the test with the operators folder.

* test pynfft on local runner.

* local runner setup pynfft2

* use venv

* fix: skip 3D tests for slow transforms.

* fix import

* ci: remove pynfft from gpu

2D is done on CPU and is good enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants