Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share a 2D nufft across Stacked Operators #87

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

paquiteau
Copy link
Member

This PR allows one to initialize a 2D NUFFT operators and reuse it across multiple definition of stacked (2.5D) NUFFT.

Tests are coming.

@paquiteau paquiteau requested a review from chaithyagr April 4, 2024 11:55
@chaithyagr
Copy link
Member

There seems to be conflicts... Can you please handle that. Also, can you please give the usecase for this? Is it for the specific case when you shall have different number of stacks so you want to reuse the 2D operator, or is it when you wangt to reconstruct different time frame volumes for a given stack ? Is there any expected performance gain (in terms of creating and destroying the backend operator)

@paquiteau
Copy link
Member Author

the typical use case is for this kind of trajectory, in the context of fMRI:
image

The 2D shot is the same everywhere, so instead of creating a new NUFFT plan for each frame, we can reuse it. This saves a significant amount of memory.

@paquiteau paquiteau merged commit 46495ca into master Apr 22, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants