Smaps estimation module in mri-nufft #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pierre-Antoine Comby <pierre-antoine.comby@crans.org>
chaithyagr
force-pushed
the
smaps
branch
4 times, most recently
from
fe897f0 to
15109c6
Compare
|
Removed the unnessary rebase which was really confusing and repetitive. |
added 3 commits
April 30, 2024 09:06
|
@paquiteau can you see the issue please, its from brainwebdl, not something I touched? Also I think now its ready for review. |
paquiteau
requested changes
May 23, 2024
Comment on lines
+6
to
+13
| """Get the density compensation function from its name.""" | ||
| try: | ||
| method = register_smaps.registry["sensitivity_maps"][name] | ||
| except KeyError as e: | ||
| raise ValueError( | ||
| f"Unknown density compensation method {name}. Available methods are \n" | ||
| f"{list(register_smaps.registry['sensitivity_maps'].keys())}" | ||
| ) from e |
| method = get_smaps(method) | ||
| if not callable(method): | ||
| raise ValueError(f"Unknown smaps method: {method}") | ||
| self.smaps, self.SOS = method( |
There was a problem hiding this comment.
Docstring should be fine. Maybe rename it as _SOS , it's not something that users should rely onto, as it is not always available. If we want to expose it we could use a property wrapping around it (and compute the SOS on the fly when this method is not used). Somethink like:
@property()
def SOS(self):
"""Returns the sum of square of the smaps.
If available, else return None"""
if not self.uses_sense:
return None
if hasattr(self, "_sos"):
return self._sos
else:
xp = get_array_module(self.smaps)
return xp.sum(self.smaps**2, axis=0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Smaps estimation module in mri-nufft to makes creation of Fourier operator streamlined.
This should be merged after #89