Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Git.Clone after 35bab8f #3587

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

evankanderson
Copy link
Member

Summary

It turns out that (in Minder, but not in the test), Git.Clone doesn't like sharing the filesystem between the workspace files and the git storer.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual testing to isolate the issue. This can probably be fixed better, but we'd like to get the basic protection into main.

This will be validated by smoke tests, which caught the issue.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner June 12, 2024 17:45
@evankanderson evankanderson mentioned this pull request Jun 12, 2024
10 tasks
blkt
blkt previously approved these changes Jun 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.231% (+0.001%) from 53.23%
when pulling 061010e on evankanderson:fix-clone
into 9cba1f3 on stacklok:main.

@coveralls
Copy link

Coverage Status

coverage: 53.236% (+0.006%) from 53.23%
when pulling 061010e on evankanderson:fix-clone
into 9cba1f3 on stacklok:main.

@evankanderson
Copy link
Member Author

Whoops, missed one lint error from the previous PR, will need another approval.

@coveralls
Copy link

Coverage Status

coverage: 53.236% (+0.006%) from 53.23%
when pulling 8d9d165 on evankanderson:fix-clone
into 9cba1f3 on stacklok:main.

@evankanderson evankanderson merged commit 7979b43 into mindersec:main Jun 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants