Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating/applying ruletypes from standard input #4959

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 13, 2024

Summary

We had added that ability in the initial implementation, but had lost it
once we started skipping files more thoroughly. This recovers that.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We had added that ability in the initial implementation, but had lost it
once we started skipping files more thoroughly. This recovers that.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner November 13, 2024 07:51
@coveralls
Copy link

Coverage Status

coverage: 54.762% (+0.007%) from 54.755%
when pulling 5fb8a53 on JAORMX:stdin-ruletype
into c1c0358 on mindersec:main.

@JAORMX JAORMX merged commit 84d517a into mindersec:main Nov 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants