Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar links update #24

Merged
merged 2 commits into from
Aug 27, 2024
Merged

navbar links update #24

merged 2 commits into from
Aug 27, 2024

Conversation

hazemahmedx0
Copy link
Member

The Docs link goes to docs.mdb.ai - it should go to docs.mindsdb.com
The Open Source -> GitHub link goes to docs.mindsdb.com - it should go to https://github.com/mindsdb/mindsdb
The Open Source -> Support link opens in the same tab (as opposed to other links in this category) - please make it open in a new tab

@martyna-mindsdb
Copy link

@hazemahmedx0
Thanks for the updates.
I listed the following changes to standardize both headers in the website and in the blog.

Overall, if the link goes outside of mindsdb.com we should open it in a new tab, but if it stays within mindsdb.com we should open it in the same tab.

In the blog header (updates to be made in this PR):

  • Docs link should open in a new tab, since it goes outside of mindsdb.com
  • Minds Cloud -> Minds Cloud link should open in a new tab, since it goes outside of mindsdb.com
  • Open Source -> Integrations link should open in a new tab, since it goes outside of mindsdb.com
  • Open Source -> GitHub link should open in a new tab, since it goes outside of mindsdb.com
  • Connect with an Expert tab should be removed - and replace it with Enterprise tab from the website

On the mindsdb.com website header (updates to be made to the website):

  • Open Source -> Community link should open in the same tab, since it doesn’t go outside of mindsdb.com

@martyna-mindsdb martyna-mindsdb merged commit f6a1a6d into main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants