-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for allow_update_branch
#155
base: main
Are you sure you want to change the base?
feat: add support for allow_update_branch
#155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I want this change to be merged in without a breaking change, this change would also require a breaking change since the minimum required provider version would have to be bumped to >= 5.7.0
.
The current provider version constraint for this module is >= 4.20, < 6.0
.
terraform-github-repository/versions.tf
Line 12 in ee6001a
version = ">= 4.20, < 6.0" |
allow_update_branch
was added in provider version v5.7.0.
So the minimum required version for this module should be bumped to at least >= 5.7.0
. Otherwise, users who has a lower provider version ( < 5.7.0 ) and use a pessimistic operator constraint for the module would have their code breaking.
This probably might be the reason why this change was also merged into #148
added require of version to be |
allow_update_branch
with default beingfalse
fix #132
rel #148 (similar except that it's not updating provider versions)