-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed: Fix #61 #505
base: master
Are you sure you want to change the base?
Completed: Fix #61 #505
Conversation
still needs making it configurable and having an optional /metrics endpoint instead of pushing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work so far, but have to consider it as incomplete. This might be frustrating news given the possible hours put in to it at so far. There is more iteration needed that might exceed your budget to invest more time.
Thats completely fine, I am fine with refining it based on your comments as you are the repo owner. Do tell me when your review is complete and i can work on from there. |
It is complete. |
@robinbraemer ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good
@robinbraemer Done with the latest review's requirements as well. |
just saw go build now includes git version |
Nice, removed git versioning flag then. |
@robinbraemer any updates on this? |
It’s on my todo list. I won’t have time for the next 2 weeks worst case for your transparency. |
Waiting for your input on this. |
I'm very busy with thesis atm. I cannot provide an estimate when I find time, sorry. |
Working on issue #61