Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed: Fix #61 #505

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Completed: Fix #61 #505

wants to merge 12 commits into from

Conversation

zelosleone
Copy link

Working on issue #61

@zelosleone zelosleone marked this pull request as ready for review February 13, 2025 14:47
@zelosleone zelosleone changed the title WIP: Fix #61 Completed: Fix #61 Feb 13, 2025
Copy link
Member

@robinbraemer robinbraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work so far, but have to consider it as incomplete. This might be frustrating news given the possible hours put in to it at so far. There is more iteration needed that might exceed your budget to invest more time.

@zelosleone
Copy link
Author

Thanks for the work so far, but have to consider it as incomplete. This might be frustrating news given the possible hours put in to it at so far. There is more iteration needed.

Thats completely fine, I am fine with refining it based on your comments as you are the repo owner. Do tell me when your review is complete and i can work on from there.

@robinbraemer
Copy link
Member

It is complete.

@zelosleone
Copy link
Author

@robinbraemer ready for review

Copy link
Member

@robinbraemer robinbraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good

@zelosleone
Copy link
Author

@robinbraemer Done with the latest review's requirements as well.

@robinbraemer
Copy link
Member

just saw go build now includes git version
https://go.dev/doc/go1.24

@zelosleone
Copy link
Author

just saw go build now includes git version go.dev/doc/go1.24

Nice, removed git versioning flag then.

@zelosleone
Copy link
Author

@robinbraemer any updates on this?

@robinbraemer
Copy link
Member

@robinbraemer any updates on this?

It’s on my todo list. I won’t have time for the next 2 weeks worst case for your transparency.

@zelosleone
Copy link
Author

@robinbraemer any updates on this?

It’s on my todo list. I won’t have time for the next 2 weeks worst case for your transparency.

Waiting for your input on this.

@robinbraemer
Copy link
Member

I'm very busy with thesis atm. I cannot provide an estimate when I find time, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants