Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix players being dragged along the side of stacks #478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix players being dragged along the side of stacks #478

wants to merge 1 commit into from

Conversation

cheapie
Copy link
Contributor

@cheapie cheapie commented Sep 1, 2019

This fixes bug #462, where players alongside a stack of nodes being moved via MVPS would be dragged along with it, ending up inside a node if one was present there.

@benrob0329
Copy link

This breaks mechanics and designs that I use in many places.

@cheapie
Copy link
Contributor Author

cheapie commented Sep 10, 2019

It fixes a bug you relied upon where pistons push things that aren't even in front of them, yes.

https://xkcd.com/1172/

@Desour
Copy link
Contributor

Desour commented Sep 10, 2019

This was done to keep a feature: #367 (comment)

@benrob0329
Copy link

benrob0329 commented Sep 10, 2019

That "bug" is what makes practical piston elevators and piston-bolts possible with mesecons, as well as reasonably moving carts around.

@cheapie
Copy link
Contributor Author

cheapie commented Sep 10, 2019

This was done to keep a feature: #367 (comment)

I can certainly attempt to re-add it in the +Y direction (so that objects on top slide with while objects that are just next to the stack don't) if you think there is interest in that. I'm not sure this is all that realistic given the instant nature of the movement - inertia would keep anything resting on top in place - but I suppose realism isn't always the goal here.

Another possibility would be to use a smaller radius for players than for other objects - this would still fix the original bug as reported, where players get pulled with a stack (and into a node if present), without removing the buggy behavior for other objects if this is what is desired. If there is any support for this, I'll either modify this PR or close it and create a new one as appropriate.

That "bug" is what makes practical piston elevators and piston-bolts possible with mesecons, as well as reasonably moving carts around.

I have no idea what a "piston-bolt" is, but there are certainly piston elevator designs that do not rely on bugs. I've even shown you one of those on VE-Creative (and you seem to like nocontroller challenges, how about a nocontroller version of that one?)
I also fail to see how moving carts around in the way you have shown is anything but a bug - carts are supposed to be on rails, not shoved off to the side at random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants