Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility with Stairs, Moreblocks #27

Closed
wants to merge 12 commits into from
Closed

Add compatibility with Stairs, Moreblocks #27

wants to merge 12 commits into from

Conversation

Jat15
Copy link

@Jat15 Jat15 commented Aug 23, 2017 •
edited
Loading

Update sound.
Fixes #13.

@Jat15 Jat15 mentioned this pull request Aug 23, 2017
Open
@Desour
Copy link

Desour commented Aug 23, 2017

You should write here to first comment Fixes #13., then it will be closed automatically by the merger on merge.
Code looks good.

@Jat15 Jat15 changed the title Add compatibility with Stairs, Moreblocks Fixes #13 Add compatibility with Stairs, Moreblocks Aug 23, 2017
@Jat15 Jat15 changed the title Fixes #13 Add compatibility with Stairs, Moreblocks Add compatibility with Stairs, Moreblocks Aug 23, 2017
@Jat15
Copy link
Author

Jat15 commented Aug 23, 2017

@DS-Minetest written in commentary.

@Jat15 Jat15 mentioned this pull request Aug 28, 2017
Closed
11 tasks
@thomasrudin
Copy link

Any progress on this? Looks like a simple addition... 😕

Panquesito7
Panquesito7 reviewed Sep 20, 2019
View reviewed changes
locale/es.txt Outdated Show resolved Hide resolved
locale/es.txt Outdated Show resolved Hide resolved
louisroyer
louisroyer suggested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@louisroyer louisroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you should rebase on master HEAD and translations you added should be moved into *.tr files (with some syntax changes).

init.lua Show resolved Hide resolved
locale/fr.txt Outdated Show resolved Hide resolved
locale/fr.txt Outdated Show resolved Hide resolved
depends.txt Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test; looks good, though. I believe More Ores should be updated, too.

@GreenDirkfried
Copy link
Contributor

GreenDirkfried commented Aug 28, 2022 •
edited
Loading

I tested this in my own fork (https://github.com/GreenDirkfried/moreores/pull/5/files) and got undefined nodes after proceeding like follows:
I started a world with the "stairs" mod included and took and placed some (mithril) stairs.
Then I closed the world and added the "moreblocks" mod, which leads to the old stairs being now undefined.
Can you confirm this problem?
I guess there should be an alias included.... @Jat15

@Jat15 Jat15 closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisroyer louisroyer louisroyer requested changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for moreblocks saw
7 participants
@Jat15 @Desour @thomasrudin @GreenDirkfried @Panquesito7 @louisroyer @Calinou