Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technic_cnc: use programs definition to generate formspec #647

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

SmallJoker
Copy link
Member

@SmallJoker SmallJoker commented Aug 2, 2024

This deprecates the variables onesize_products and twosize_products by using a shared definition table.
With these changes, it should be easier to add new programs in the future.

New feature: Tooltips are added to all programs. (only applies to newly placed nodes)

Before:

grafik

After:

grafik

How to test:

  1. Place a CNC using the current technic master version
  2. Ensure that it the CNC cuts properly
  3. Apply this PR
  4. Ensure that it the CNC cuts properly
  5. Place a new CNC
  6. Ensure that it the CNC cuts properly

This deprecates the variables onesize_products and twosize_products
by using a shared definition table.
@SmallJoker SmallJoker merged commit 221fc13 into master Aug 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant