[no sq] Kick players from beds that have ceased existing #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
changed the title
|
I have no issues with this approach but shouldn't |
SmallJoker
reviewed
Nov 16, 2024
I think so, yes. VoxelManips might appear naturally in gameplay though, e.g. explosions - you still want the player to be kicked from bed when it was blown up (we could now start with |
|
The sleep formspec does neither get closed nor updated on kick. Is that intentional? Granted, it does precisely fix the linked issue.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3167. Done via a globalstep, which is not a concern. I believe this to be the most straightforward approach; it is unrealistic to efficiently hook all possible ways the node could be removed.