fix: Refactor on-premises service names for consistency #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeaaoliveira
added
area/provider/azure
|
There's missing Breaking Changes in the changelog: for: You can copy paste the previous structure. |
|
@gabriel-tessier This has been updated as well. |
gabriel-tessier
requested changes
Oct 5, 2024
There was a problem hiding this comment.
@filipeaaoliveira
You added the changes in the 0.16.0 section, better to create a new section 0.23.5 on the top of the file with the changes.
In worst case if the PR don't ship in the next version we just need to update the version number after merge with master.
gabriel-tessier
approved these changes
Oct 14, 2024
filipeaaoliveira
deleted the
1020-fix-the-spelling-typo-onprem-=-on-premises-not-premise
branch
|
Thank you guys!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses the issue of incorrect usage of the term "premise" across the codebase and documentation. In all relevant instances, "premise" has been updated to "premises" to reflect the proper plural form.
Changes:
Replaced all instances of "premise" with "premises" in both code comments and documentation.
Rationale:
The term "premise" refers to a singular proposition or assumption, while "premises" is typically used when referring to a set of assumptions or statements, particularly in technical contexts. This correction improves the accuracy and professionalism of the codebase and documentation.