Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the SQL programing language and the SQLPage framework #1047

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Nov 5, 2024

The SQL icon was created by me.

The SQLPage icon is the official one from https://sql.datapage.app/

@gabriel-tessier
Copy link
Collaborator

Thanks for the PR,

First as stated in the contributing file the icon must be maximum 256px, yours is 258, and also you need to run autogen script.

You can read all the details about here: about the https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

About SQL icon it's not that I don't like the icon you created but I quickly searched and found this one, which is a little more modern:
https://www.vectorstock.com/royalty-free-vector/sql-database-icon-logo-design-ui-or-ux-app-vector-17507753

@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 17, 2024

The image you linked cannot be distributed under the MIT license of this project. I generated a new, hopefully better looking one; let me know what you think

@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 17, 2024

About autogen: I don't have the required cli tools and cannot install them. Could you please run it for me ? Edits by maintainers are allowed on this pr.

@gabriel-tessier
Copy link
Collaborator

@lovasoa Thanks for the icons I will run autogen later this week.

@gabriel-tessier gabriel-tessier self-assigned this Nov 18, 2024
@gabriel-tessier gabriel-tessier added the area/provider/programming Programming provider label Nov 20, 2024
@tvqphuoc01 tvqphuoc01 merged commit fe3b9cc into mingrammer:master Nov 23, 2024
7 checks passed
@lovasoa lovasoa deleted the sql branch November 23, 2024 15:27
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 23, 2024

thanks 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/programming Programming provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants