-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the SQL programing language and the SQLPage framework #1047
Conversation
Thanks for the PR, First as stated in the contributing file the icon must be maximum 256px, yours is 258, and also you need to run autogen script. You can read all the details about here: about the https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md About SQL icon it's not that I don't like the icon you created but I quickly searched and found this one, which is a little more modern: |
The image you linked cannot be distributed under the MIT license of this project. I generated a new, hopefully better looking one; let me know what you think |
About autogen: I don't have the required cli tools and cannot install them. Could you please run it for me ? Edits by maintainers are allowed on this pr. |
@lovasoa Thanks for the icons I will run autogen later this week. |
thanks 💯 |
The SQL icon was created by me.
The SQLPage icon is the official one from https://sql.datapage.app/