Add diagrams.onprem.network.Mikrotik #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example
|
|
@nobiit The logo you submitted is different than the one on their website. Also check the instructions about the icon size here: about the https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md |
nobiit
force-pushed
the
features/add_mikrotik
branch
from
7eecf57 to
622f988
Compare
|
|
|
I changed the logo to exactly 256px, thanks for the advice. @gabriel-tessier Can you check it for me? |
nobiit
force-pushed
the
features/add_mikrotik
branch
from
622f988 to
1e41e26
Compare
gabriel-tessier
approved these changes
Nov 18, 2024
gabriel-tessier
requested review from
mingrammer,
tvqphuoc01 and
filipeaaoliveira
tvqphuoc01
approved these changes
Nov 18, 2024
gabriel-tessier
pushed a commit
that referenced
this pull request
Nov 20, 2024
gabriel-tessier
added a commit
that referenced
this pull request
Jan 13, 2025
* [979] Add icons * fix: icons size * bump: up to version 0.24.0 * Update version of codeql-analysis.yml (#1035) v2 will deprecate soon so we will move to v3 🌴 https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/ * Upgrade for 3.12/3.13 (#972) * fix tests (#1050) * chore(deps): bump jinja2 from 3.1.2 to 3.1.4 (#1037) * ci(test): add test trigger path * ci(test): add test trigger path * fix: update poetry lock * fix: keep the backward compatability for type hint (#1052) * Update installation command for mingrammer/round to use 'go install' with the latest version instead of 'go get'. (#1057) * fix(node): change elixir language image to one with no background (#976) * fix elixir image * fix website elixir image * Add diagrams.onprem.network.Mikrotik (#1058) * issue-982: add azure speech to text and Azure OpenAI (#1061) * Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. (#1038) * issue-1056: add crowdstrike (#1062) * fix typo for crowdstrike (#1063) * Updated Legacy ENV Path (#1008) * Minor Change * fix: pin python version + fix font path * More recent Python version --------- Co-authored-by: tessier <tessier@luxeys.com> * autogen.sh * Generate node * Revert build as node and set in _init * Clean generated files --------- Co-authored-by: mingrammer <mingrammer@gmail.com> Co-authored-by: Phuoc Tran <57540319+tvqphuoc01@users.noreply.github.com> Co-authored-by: Tobias Bruckert <62531735+tb102122@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nguyễn Đức Chiến <nobi@nobidev.com> Co-authored-by: Gabriel Oliveira <gabrieloliver8991@gmail.com> Co-authored-by: laiminhtrung1997 <68812829+laiminhtrung1997@users.noreply.github.com> Co-authored-by: Abhishek Jadhav <abhishek.jadhav64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Mikrotik as it is also quite popular
Website: https://mikrotik.com/