Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate tableau and metabase nodes #142

Merged
merged 2 commits into from
May 17, 2020
Merged

generate tableau and metabase nodes #142

merged 2 commits into from
May 17, 2020

Conversation

wurthmvnn
Copy link
Contributor

generate new nodes for visualization tools: tableau and metabase

@wurthmvnn
Copy link
Contributor Author

Hello! @mingrammer
The project is wonderful,
I use it to build new diagrams for the AWS data pipeline of my work and for that I needed to generate new tableau and metabase nodes! that was amazing!!! Thank you

@mingrammer
Copy link
Owner

Please resolve the conflicts :)

@mingrammer mingrammer added area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request labels May 17, 2020
@wurthmvnn wurthmvnn closed this May 17, 2020
@wurthmvnn wurthmvnn reopened this May 17, 2020
@wurthmvnn
Copy link
Contributor Author

done!

mingrammer
mingrammer approved these changes May 17, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions!

@mingrammer mingrammer merged commit c046b8a into mingrammer:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wurthmvnn @mingrammer