-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodes for Firebase #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingrammer
requested changes
May 24, 2020
mingrammer
added
comp/node
Issue of node component
kind/feat/provider
Provider request
labels
May 24, 2020
mingrammer
reviewed
May 25, 2020
mingrammer
approved these changes
May 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!!
nlamirault
added a commit
to nlamirault/diagrams
that referenced
this pull request
Jun 4, 2020
* master: (23 commits) Added generic itens and blank cluster (mingrammer#171) bump: up to version 0.13.1 fix: add missing firebase base class docs: fix i18n docs(web): add sponsoring docs: fix Saas to SaaS docs: add more badges docs: add a sponsorship link :) docs: add firebase, elastic, and saas categories bump: up to version 0.13.0 AWS: Added more DynamoDB and IAM resources (mingrammer#180) Add elastic stack (mingrammer#134) (mingrammer#174) Add Rust programming language (mingrammer#179) Add flux and flagger (mingrammer#147) Add Saas v2 (mingrammer#89) (mingrammer#173) Add nodes for Firebase (mingrammer#167) Add ZuulCI as onprem CI resource (mingrammer#145) bump: up to version 0.12.0 Add GitlabCI to onprem.ci section (mingrammer#166) Add Sentry to onperm.monitoring (mingrammer#165) ... Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
nlamirault
added a commit
to nlamirault/diagrams
that referenced
this pull request
Jun 4, 2020
* master: (23 commits) Added generic itens and blank cluster (mingrammer#171) bump: up to version 0.13.1 fix: add missing firebase base class docs: fix i18n docs(web): add sponsoring docs: fix Saas to SaaS docs: add more badges docs: add a sponsorship link :) docs: add firebase, elastic, and saas categories bump: up to version 0.13.0 AWS: Added more DynamoDB and IAM resources (mingrammer#180) Add elastic stack (mingrammer#134) (mingrammer#174) Add Rust programming language (mingrammer#179) Add flux and flagger (mingrammer#147) Add Saas v2 (mingrammer#89) (mingrammer#173) Add nodes for Firebase (mingrammer#167) Add ZuulCI as onprem CI resource (mingrammer#145) bump: up to version 0.12.0 Add GitlabCI to onprem.ci section (mingrammer#166) Add Sentry to onperm.monitoring (mingrammer#165) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Firebase from existing iconset #118.
And chganed directories to match Firebase category (see the image below).
On my MacOS, sort of
type
is broken in api documents by usingautogen.sh
. So I fiexed it together.