Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodes for Firebase #167

Merged
merged 4 commits into from
May 25, 2020
Merged

Add nodes for Firebase #167

merged 4 commits into from
May 25, 2020

Conversation

zoeponta
Copy link
Contributor

@zoeponta zoeponta commented May 23, 2020

Added Firebase from existing iconset #118.
And chganed directories to match Firebase category (see the image below).

firebase-menu

On my MacOS, sort of type is broken in api documents by using autogen.sh. So I fiexed it together.

scripts/generate.py Outdated Show resolved Hide resolved
config.py Outdated Show resolved Hide resolved
@mingrammer mingrammer added comp/node Issue of node component kind/feat/provider Provider request labels May 24, 2020
@zoeponta zoeponta requested a review from mingrammer May 24, 2020 14:48
config.py Outdated Show resolved Hide resolved
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@mingrammer mingrammer merged commit f8ba6a8 into mingrammer:master May 25, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/node Issue of node component kind/feat/provider Provider request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants