Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: containers tools into programming #188

Merged

Conversation

nlamirault
Copy link
Contributor

Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@mingrammer
Copy link
Owner

I think helm, krew, and kustomize should be under the kubernetes provider. What do you think about diagrams.kubernetes.ecosystem or diagrams.kubernetes.tools?

@nlamirault
Copy link
Contributor Author

I prefer diagrams.kubernetes.ecosystem. tools is too generic i think. I could update the MR.

@mingrammer mingrammer added area/provider/k8s Kubernetes provider comp/node Issue of node component kind/feat/icon Icon request labels Jun 4, 2020
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
diagrams/programming/containers.py Outdated Show resolved Hide resolved
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the k8s.ecosystem in the k8s.md

docs/nodes/k8s.md Outdated Show resolved Hide resolved
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@mingrammer mingrammer merged commit 43120a7 into mingrammer:master Jun 5, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 12, 2020
* master:
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /website (mingrammer#194)
  Add more analytics tools (mingrammer#195)
  AWS: Added 9 more resource groups (mingrammer#192)
  docs: update badge status
  ci: install graphviz
  ci: install python dependencies
  ci: install poetry with pip
  ci: fix poetry bin path
  ci: fix job file path
  ci: update run test job
  scripts(generate): shorten usage
  ci: add run test job
  refactor: reformat the config.py
  Add: containers tools into programming (mingrammer#188)
  lint: new line spaces
  refactor: use official beats icon
  Add: new component Beats from Elasticstack (mingrammer#153)
  Added more generic icons mingrammer#126 (mingrammer#186)

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
Copy link
Contributor Author

@mingrammer changelog of release v0.14.0 https://github.com/mingrammer/diagrams/releases/tag/v0.14.0 is wrong on this PR. (168 instead of 188).

Do you know when website will be available with new resources ?

@mingrammer
Copy link
Owner

@nlamirault Sorry for that :(. I updated the changelog now. And the latest documentation is now published! (k8s.ecosystem: https://diagrams.mingrammer.com/docs/nodes/k8s#k8secosystem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/k8s Kubernetes provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants