feat(output): Generate dot file and support multi outformat.(#441) Re #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To integrate diagrams in existing docs-as-code toolchains this feature is absolutely needed. Thanks @gabriel-tessier! Any ideas when the pr will be merged and a new release will follow? |
|
Thanks @gabriel-tessier for this PR @mingrammer I saw that you approved previous PR with changes for dot file generation - do you have any plans to approve and merge this PR? |
mingrammer
reviewed
Jan 21, 2022
haad
added a commit
to haad/diagrams
that referenced
this pull request
May 12, 2022
* mhmdio/master: bump: up to version 0.21.1 feat(output): Generate dot file and support multi outformat.(mingrammer#441) Re (mingrammer#592) feat: add digitalocean provider (mingrammer#646) docs(website): update docs bump: up to version 0.21.0 docs(readme): update badges docs(readme): update docs(readme): add digital ocean badge feat(provider): added DigitalOcean provider (mingrammer#621) feat(node): Dremio Service in OnPrem.Analytics (mingrammer#451) chore(deps): bump shelljs from 0.8.4 to 0.8.5 in /website (mingrammer#641) feat(node): add Nagios in OnPrem monitoring (mingrammer#638) feat(node): adding GCP API gateway image (mingrammer#636) feat(node): add chatbot icon (mingrammer#633) chore(deps): bump graphviz from 0.17 to 0.19.1 (mingrammer#635) feat(node): added Dapr programming runtime (mingrammer#591) docs: add mac dev guide (mingrammer#576) docs(readme): add Python 3.9 to badges (mingrammer#584) 👌 IMPROVE: HashiCorp Icons 📦 NEW: Add remaining HashiCorp Icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lost this branch on my local but I was able to pull the pr, but I can no more link it with the previous PR so I open a new one.
Sorry for the inconvenience.
Replace the previous PR #446