Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Edge attributes exist before setting #96

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Verify Edge attributes exist before setting #96

merged 1 commit into from
Apr 17, 2020

Conversation

RyanMillerC
Copy link
Contributor

Fixes #95.

This fixes the issue of Edge attributes being overwritten by empty strings, causing default values to be replaced with Graphviz defaults.

  • Only set Graphviz attributes if they are not empty strings

mingrammer
mingrammer approved these changes Apr 17, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingrammer
Copy link
Owner

Thank you :)

@mingrammer mingrammer merged commit cff498e into mingrammer:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default edge_attr Values are Masked by Graphviz Defaults
2 participants
@RyanMillerC @mingrammer