Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete a stale test that's hard-coded to pass #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delete a stale test that's hard-coded to pass #337

wants to merge 1 commit into from

Conversation

mihbor
Copy link

@mihbor mihbor commented Jul 13, 2021

The class under test (App) doesn't exist (anymore?) in this project, so cannot hope to improve the test. I think it's best to delete.

@mihbor
delete a stale test that's hard-coded to pass, the class under test d…
94a21e1 
…oesn't exist (anymore?), so cannot hope to improve it
@eurobuddha eurobuddha added the good first issue Good for newcomers label Jul 13, 2021
@eurobuddha eurobuddha added this to the Low milestone Jul 13, 2021
@eurobuddha eurobuddha removed the good first issue Good for newcomers label Jul 13, 2021
@eurobuddha eurobuddha removed this from the Low milestone Jul 13, 2021
Swiftyos
Swiftyos approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@Swiftyos Swiftyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftyos Swiftyos Swiftyos approved these changes

@spartacusrex99 spartacusrex99 Awaiting requested review from spartacusrex99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mihbor @Swiftyos @jeromerousselot @stevie101 @spartacusrex99 @eurobuddha @s-jita-digital