Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new subpackage opencryptoki-ccatok for rhel-10.0/c10s #1303

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ngothan
Copy link
Contributor

@ngothan ngothan commented Oct 22, 2024

add new subpackage opencryptoki-ccatok for rhel-10.0/c10s

@ngothan
Copy link
Contributor Author

ngothan commented Oct 22, 2024

Hi @yselkowitz, could you please help me to merge this. It's needed for https://issues.redhat.com/browse/RHEL-39004

https://errata.devel.redhat.com/advisory/140177/builds

Thank you!

Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, this needs to be rebased against main; this should only consist of a single commit.

Furthermore, opencryptoki-ccatok is not built for aarch64, therefore it cannot be listed unconditionally. Instead, the existing s390x listing must remain, and this package be added to the ppc64le and x86_64 lists.

Finally, while we do want this fixed here, Content Resolver does not determine the content of composes. Therefore, this is not the blocking factor for your errata. In order to add this subpackage to other arches, you will need to file an ENGCMP ticket to have it added on those arches in pungi-centos.

@ngothan ngothan reopened this Oct 22, 2024
@ngothan
Copy link
Contributor Author

ngothan commented Oct 22, 2024

@yselkowitz , i rebased the PR, keeped the s390x listing and added opencryptoki-ccatok in x86_64 and ppc64le list

@yselkowitz yselkowitz merged commit 21839cd into minimization:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants