fix: possible nil deref in admin_info (#3500)

minio · Feb 11, 2025 · 115de8e · 115de8e
1 parent 27cb17d
commit 115de8e
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/api/admin_info.go b/api/admin_info.go
@@ -1121,12 +1121,13 @@ LabelsWaitLoop:
 				if inStep != nil && *inStep > 0 {
 					step = *inStep
 				}
-				if step > 0 {
-					extraParamters = fmt.Sprintf("%s&step=%d", extraParamters, step)
-				}
 
 				if inStart != nil && inEnd != nil {
-					extraParamters = fmt.Sprintf("&start=%d&end=%d&step=%d", *inStart, *inEnd, *inStep)
+					extraParamters = fmt.Sprintf("&start=%d&end=%d", *inStart, *inEnd)
+				}
+
+				if step > 0 {
+					extraParamters = fmt.Sprintf("%s&step=%d", extraParamters, step)
 				}
 
 				// replace the `$__rate_interval` global for step with unit (s for seconds)