-
Notifications
You must be signed in to change notification settings - Fork 298
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This PR sets the initial version of the ACL for mcs, the idea behind
this is to start using the principle of least privileges when assigning
policies to users when creating users through mcs, currently mcsAdmin policy uses admin:*
and s3:* and by default a user with that policy will have access to everything, if want to limit
that we can create a policy with least privileges.
We need to start validating explicitly if users has acccess to an
specific endpoint based on IAM policy actions.
In this first version every endpoint (you can see it as a page to),
defines a set of well defined admin/s3 actions to work properly, ie:
```
// corresponds to /groups endpoint used by the groups page
var groupsActionSet = iampolicy.NewActionSet(
iampolicy.ListGroupsAdminAction,
iampolicy.AddUserToGroupAdminAction,
//iampolicy.GetGroupAdminAction,
iampolicy.EnableGroupAdminAction,
iampolicy.DisableGroupAdminAction,
)
// corresponds to /policies endpoint used by the policies page
var iamPoliciesActionSet = iampolicy.NewActionSet(
iampolicy.GetPolicyAdminAction,
iampolicy.DeletePolicyAdminAction,
iampolicy.CreatePolicyAdminAction,
iampolicy.AttachPolicyAdminAction,
iampolicy.ListUserPoliciesAdminAction,
)
```
With that said, for this initial version, now the sessions endpoint will
return a list of authorized pages to be render on the UI, on subsequent
prs we will add this verification of authorization via a server
middleware.- Loading branch information
Showing
23 changed files
with
1,080 additions
and
335 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,268 @@ | ||
| // This file is part of MinIO Console Server | ||
| // Copyright (c) 2020 MinIO, Inc. | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| package acl | ||
|
|
||
| import iampolicy "github.com/minio/minio/pkg/iam/policy" | ||
|
|
||
| // endpoints definition | ||
| var ( | ||
| configuration = "/configurations-list" | ||
| users = "/users" | ||
| groups = "/groups" | ||
| iamPolicies = "/policies" | ||
| dashboard = "/dashboard" | ||
| profiling = "/profiling" | ||
| trace = "/trace" | ||
| logs = "/logs" | ||
| watch = "/watch" | ||
| notifications = "/notification-endpoints" | ||
| buckets = "/buckets" | ||
| ) | ||
|
|
||
| type ConfigurationActionSet struct { | ||
| actionTypes iampolicy.ActionSet | ||
| actions iampolicy.ActionSet | ||
| } | ||
|
|
||
| // configurationActionSet contains the list of admin actions required for this endpoint to work | ||
| var configurationActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ConfigUpdateAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // logsActionSet contains the list of admin actions required for this endpoint to work | ||
| var logsActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ConsoleLogAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // dashboardActionSet contains the list of admin actions required for this endpoint to work | ||
| var dashboardActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ServerInfoAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // groupsActionSet contains the list of admin actions required for this endpoint to work | ||
| var groupsActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ListGroupsAdminAction, | ||
| iampolicy.AddUserToGroupAdminAction, | ||
| //iampolicy.GetGroupAdminAction, | ||
| iampolicy.EnableGroupAdminAction, | ||
| iampolicy.DisableGroupAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // iamPoliciesActionSet contains the list of admin actions required for this endpoint to work | ||
| var iamPoliciesActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.GetPolicyAdminAction, | ||
| iampolicy.DeletePolicyAdminAction, | ||
| iampolicy.CreatePolicyAdminAction, | ||
| iampolicy.AttachPolicyAdminAction, | ||
| iampolicy.ListUserPoliciesAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // profilingActionSet contains the list of admin actions required for this endpoint to work | ||
| var profilingActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ProfilingAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // traceActionSet contains the list of admin actions required for this endpoint to work | ||
| var traceActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.TraceAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // usersActionSet contains the list of admin actions required for this endpoint to work | ||
| var usersActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ListUsersAdminAction, | ||
| iampolicy.CreateUserAdminAction, | ||
| iampolicy.DeleteUserAdminAction, | ||
| iampolicy.GetUserAdminAction, | ||
| iampolicy.EnableUserAdminAction, | ||
| iampolicy.DisableUserAdminAction, | ||
| ), | ||
| } | ||
|
|
||
| // watchActionSet contains the list of admin actions required for this endpoint to work | ||
| var watchActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllAdminActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ListenBucketNotificationAction, | ||
| ), | ||
| } | ||
|
|
||
| // notificationsActionSet contains the list of admin actions required for this endpoint to work | ||
| var notificationsActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| iampolicy.ListenBucketNotificationAction, | ||
| iampolicy.PutBucketNotificationAction, | ||
| iampolicy.GetBucketNotificationAction, | ||
| ), | ||
| } | ||
|
|
||
| // bucketsActionSet contains the list of admin actions required for this endpoint to work | ||
| var bucketsActionSet = ConfigurationActionSet{ | ||
| actionTypes: iampolicy.NewActionSet( | ||
| iampolicy.AllActions, | ||
| ), | ||
| actions: iampolicy.NewActionSet( | ||
| // Read access to buckets | ||
| iampolicy.ListMultipartUploadPartsAction, | ||
| iampolicy.ListBucketMultipartUploadsAction, | ||
| iampolicy.ListBucketAction, | ||
| iampolicy.HeadBucketAction, | ||
| iampolicy.GetObjectAction, | ||
| iampolicy.GetBucketLocationAction, | ||
| // Write access to buckets | ||
| iampolicy.AbortMultipartUploadAction, | ||
| iampolicy.CreateBucketAction, | ||
| iampolicy.PutObjectAction, | ||
| iampolicy.DeleteObjectAction, | ||
| iampolicy.DeleteBucketAction, | ||
| // Assign bucket policies | ||
| iampolicy.PutBucketPolicyAction, | ||
| iampolicy.DeleteBucketPolicyAction, | ||
| iampolicy.GetBucketPolicyAction, | ||
| ), | ||
| } | ||
|
|
||
| // endpointRules contains the mapping between endpoints and ActionSets, additional rules can be added here | ||
| var endpointRules = map[string]ConfigurationActionSet{ | ||
| configuration: configurationActionSet, | ||
| users: usersActionSet, | ||
| groups: groupsActionSet, | ||
| iamPolicies: iamPoliciesActionSet, | ||
| dashboard: dashboardActionSet, | ||
| profiling: profilingActionSet, | ||
| trace: traceActionSet, | ||
| logs: logsActionSet, | ||
| watch: watchActionSet, | ||
| notifications: notificationsActionSet, | ||
| buckets: bucketsActionSet, | ||
| } | ||
|
|
||
| // GetActionsStringFromPolicy extract the admin/s3 actions from a given policy and return them in []string format | ||
| // | ||
| // ie: | ||
| // { | ||
| // "Version": "2012-10-17", | ||
| // "Statement": [{ | ||
| // "Action": [ | ||
| // "admin:ServerInfo", | ||
| // "admin:CreatePolicy", | ||
| // "admin:GetUser" | ||
| // ], | ||
| // ... | ||
| // }, | ||
| // { | ||
| // "Action": [ | ||
| // "s3:ListenBucketNotification", | ||
| // "s3:PutBucketNotification" | ||
| // ], | ||
| // ... | ||
| // } | ||
| // ] | ||
| // } | ||
| // Will produce an array like: ["admin:ServerInfo", "admin:CreatePolicy", "admin:GetUser", "s3:ListenBucketNotification", "s3:PutBucketNotification"]\ | ||
| func GetActionsStringFromPolicy(policy *iampolicy.Policy) []string { | ||
| var actions []string | ||
| for _, statement := range policy.Statements { | ||
| // We only care about allowed actions | ||
| if statement.Effect.IsAllowed(true) { | ||
| for _, action := range statement.Actions.ToSlice() { | ||
| actions = append(actions, string(action)) | ||
| } | ||
| } | ||
| } | ||
| return actions | ||
| } | ||
|
|
||
| // actionsStringToActionSet convert a given string array to iampolicy.ActionSet structure | ||
| // this avoids ending with duplicate actions | ||
| func actionsStringToActionSet(actions []string) iampolicy.ActionSet { | ||
| actionsSet := iampolicy.ActionSet{} | ||
| for _, action := range actions { | ||
| actionsSet.Add(iampolicy.Action(action)) | ||
| } | ||
| return actionsSet | ||
| } | ||
|
|
||
| // GetAuthorizedEndpoints return a list of allowed endpoint based on a provided *iampolicy.Policy | ||
| // ie: pages the user should have access based on his current privileges | ||
| func GetAuthorizedEndpoints(actions []string) []string { | ||
| if len(actions) == 0 { | ||
| return []string{} | ||
| } | ||
| // Prepare new ActionSet structure that will hold all the user actions | ||
| userAllowedAction := actionsStringToActionSet(actions) | ||
| allowedEndpoints := []string{} | ||
| for endpoint, rules := range endpointRules { | ||
| // check if user policy matches s3:* or admin:* typesIntersection | ||
| endpointActionTypes := rules.actionTypes | ||
| typesIntersection := endpointActionTypes.Intersection(userAllowedAction) | ||
| if len(typesIntersection) == len(endpointActionTypes.ToSlice()) { | ||
| allowedEndpoints = append(allowedEndpoints, endpoint) | ||
| continue | ||
| } | ||
| // check if user policy matches explicitly defined endpoint required actions | ||
| endpointRequiredActions := rules.actions | ||
| actionsIntersection := endpointRequiredActions.Intersection(userAllowedAction) | ||
| if len(actionsIntersection) == len(endpointRequiredActions.ToSlice()) { | ||
| allowedEndpoints = append(allowedEndpoints, endpoint) | ||
| } | ||
| } | ||
| return allowedEndpoints | ||
| } |
Oops, something went wrong.