Support for Safari #184
Comments
|
nice catch @jaredkipe I see the behavior, strangely enough, on local it doesn't happen, only when deployed, we'll investigate. |
|
I see that the cookie is getting attached on localhost but not when deployed online, however we are actually passing the On Local Deployed (play) |
Alevsk
added a commit
to Alevsk/console
that referenced
this issue
Jun 30, 2020
fixes: minio#184 There was a bug in Safari in related to the browser not setting the session token correctly in localstorage, this was because we were using window.location.href for redirect instead of history.push after login, the redirect execution was faster was faster that the promise function getting the response after the login request and it seems to be that Safari will kill all current request of a window when the page is getting redirected. Test this: Try to sign-in using Safari browser (latest version is recommended)
Alevsk
added a commit
to Alevsk/console
that referenced
this issue
Jun 30, 2020
fixes: minio#184 There was a bug in Safari in related to the browser not setting the session token correctly in localstorage, this was because we were using window.location.href for redirect instead of history.push after login, the redirect execution was faster was faster that the promise function getting the response after the login request and it seems to be that Safari will kill all current request of a window when the page is getting redirected. Test this: Try to sign-in using Safari browser (latest version is recommended)
Alevsk
added a commit
to Alevsk/console
that referenced
this issue
Jun 30, 2020
fixes: minio#184 There was a bug in Safari in related to the browser not setting the session token correctly in localstorage, this was because we were using window.location.href for redirect instead of history.push after login, the redirect execution was faster was faster that the promise function getting the response after the login request and it seems to be that Safari will kill all current request of a window when the page is getting redirected. Test this: Try to sign-in using Safari browser (latest version is recommended)
Alevsk
added a commit
that referenced
this issue
Jun 30, 2020
fixes: #184 There was a bug in Safari in related to the browser not setting the session token correctly in localstorage, this was because we were using window.location.href for redirect instead of history.push after login, the redirect execution was faster was faster that the promise function getting the response after the login request and it seems to be that Safari will kill all current request of a window when the page is getting redirected. Test this: Try to sign-in using Safari browser (latest version is recommended)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Safari, Login page works for getting errors when credentials are wrong, but when you provide correct credentials the page reloads and you do not get any visible errors anywhere.
the 'token' cookie does get set, and it does have the correct domain/content.
there is no local storage created
FF has both after login.
The text was updated successfully, but these errors were encountered: