Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed delete bucket event functionality #109

Merged
merged 1 commit into from
May 9, 2020
Merged

Fixed delete bucket event functionality #109

merged 1 commit into from
May 9, 2020

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 9, 2020

fixes #101

What does this do?

Fixes delete bucket event functionality, calling the correct API & parameters

How to test

  • Go into bucket details & add a couple of new events
  • Click on delete button for the bucket, the selected event should be deleted & nothing else

@bexsoft bexsoft requested review from Alevsk, cesnietor and dvaldivia May 9, 2020 02:31
@bexsoft bexsoft self-assigned this May 9, 2020
@bexsoft bexsoft requested a review from harshavardhana May 9, 2020 02:34
cesnietor
cesnietor approved these changes May 9, 2020
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, events are now deleted correctly.

@dvaldivia dvaldivia merged commit 0f77a32 into minio:master May 9, 2020
@bexsoft bexsoft deleted the event-delete-fix-merge branch May 13, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesnietor cesnietor cesnietor approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

Assignees

@bexsoft bexsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Bucket delete event throwing error
3 participants
@bexsoft @cesnietor @dvaldivia